test : just complete

lib/auth/server.test.ts

@@ -1,6 +1,6 @@
 import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
 
-const mocks = vi.hoisted(() => ({ session: vi.fn(), auth: vi.fn() }));
+const mocks = { session: vi.fn(), auth: vi.fn() };
 vi.mock("server-only", () => ({}));
 vi.mock("@/db", () => ({ getDb: () => ({}) }));
 vi.mock("next/headers", () => ({ headers: async () => new Headers() }));
@@ -9,20 +9,30 @@ vi.mock("better-auth/adapters/drizzle", () => ({ drizzleAdapter: () => ({}) }));
 vi.mock("better-auth/next-js", () => ({ nextCookies: () => ({}) }));
 vi.mock("better-auth/plugins", () => ({ admin: (options: unknown) => options, captcha: () => ({}) }));
 
+const envNames = ["NODE_ENV", "DATABASE_URL", "BETTER_AUTH_URL", "BETTER_AUTH_SECRET", "BUZZ_DEMO_MODE"] as const;
+const testEnv = process.env as Record<string, string | undefined>;
+const originalEnv = envNames.map((name) => testEnv[name]);
+
 beforeEach(() => {
-  vi.resetModules();
-  vi.stubEnv("NODE_ENV", "development");
-  vi.stubEnv("DATABASE_URL", "postgresql://test.invalid/test");
-  vi.stubEnv("BETTER_AUTH_URL", "https://guide.example.test");
-  vi.stubEnv("BETTER_AUTH_SECRET", "a-test-secret-with-more-than-32-characters");
+  vi.resetModules?.();
+  testEnv.NODE_ENV = "development";
+  testEnv.DATABASE_URL = "postgresql://test.invalid/test";
+  testEnv.BETTER_AUTH_URL = "https://guide.example.test";
+  testEnv.BETTER_AUTH_SECRET = "a-test-secret-with-more-than-32-characters";
   mocks.auth.mockReturnValue({ api: { getSession: mocks.session } });
   mocks.session.mockResolvedValue(null);
 });
-afterEach(() => vi.unstubAllEnvs());
+afterEach(() => {
+  envNames.forEach((name, index) => {
+    const value = originalEnv[index];
+    if (value === undefined) delete testEnv[name];
+    else testEnv[name] = value;
+  });
+});
 
 describe("actual administrator session boundary", () => {
   it("does not grant access when the old demo flag is enabled", async () => {
-    vi.stubEnv("BUZZ_DEMO_MODE", "true");
+    testEnv.BUZZ_DEMO_MODE = "true";
     const { getAdminSession, requireAdmin } = await import("./server");
     expect(await getAdminSession()).toBeNull();
     await expect(requireAdmin()).rejects.toMatchObject({ status: 401 });

lib/security/http.test.ts

@@ -1,12 +1,20 @@
-import { afterEach, describe, expect, it, vi } from "vitest";
+import { afterEach, describe, expect, it } from "vitest";
 import { boundedBody, errorResponse, HttpError, readJson, requireSameOrigin, withUploadSlot } from "./http";
 import { trustedClientAddress } from "./rate-limit";
 
-afterEach(() => vi.unstubAllEnvs());
+const originalAuthUrl = process.env.BETTER_AUTH_URL;
+const originalClientIpHeader = process.env.TRUSTED_CLIENT_IP_HEADER;
+
+afterEach(() => {
+  if (originalAuthUrl === undefined) delete process.env.BETTER_AUTH_URL;
+  else process.env.BETTER_AUTH_URL = originalAuthUrl;
+  if (originalClientIpHeader === undefined) delete process.env.TRUSTED_CLIENT_IP_HEADER;
+  else process.env.TRUSTED_CLIENT_IP_HEADER = originalClientIpHeader;
+});
 
 describe("request boundaries", () => {
   it("compares origin to configuration, not attacker-controlled Host", () => {
-    vi.stubEnv("BETTER_AUTH_URL", "https://guide.example.test");
+    process.env.BETTER_AUTH_URL = "https://guide.example.test";
     expect(() => requireSameOrigin(new Request("https://evil.test", { headers: { origin: "https://evil.test", host: "evil.test" } }))).toThrow("cross-origin");
     expect(() => requireSameOrigin(new Request("http://internal", { headers: { origin: "https://guide.example.test" } }))).not.toThrow();
     expect(() => requireSameOrigin(new Request("http://internal"))).toThrow("cross-origin");
@@ -54,9 +62,9 @@ describe("request boundaries", () => {
   });
 
   it("ignores spoofed forwarding headers unless explicitly configured", () => {
-    vi.stubEnv("TRUSTED_CLIENT_IP_HEADER", "");
+    process.env.TRUSTED_CLIENT_IP_HEADER = "";
     expect(trustedClientAddress(new Headers({ "x-forwarded-for": "1.2.3.4" }))).toBe("unknown");
-    vi.stubEnv("TRUSTED_CLIENT_IP_HEADER", "x-real-ip");
+    process.env.TRUSTED_CLIENT_IP_HEADER = "x-real-ip";
     expect(trustedClientAddress(new Headers({ "x-real-ip": "1.2.3.4, 5.6.7.8" }))).toBe("unknown");
     expect(trustedClientAddress(new Headers({ "x-real-ip": "::ffff:192.0.2.1" }))).toBe("192.0.2.1");
     expect(trustedClientAddress(new Headers({ "x-real-ip": "2001:db8:1:2::1234" })))